Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase galaxy page size to reduce number of requests #245

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Jan 30, 2021

Increate the requested version list page size to 100 (default is 10) to reduce number of queries made. (100 is the maximum size; see https://github.com/ansible/galaxy/blob/devel/galaxy/api/v2/pagination.py#L21)

Copy link
Contributor

@dmsimard dmsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

I tested it and it doesn't fix all the HTTP 520 errors but it does save on the amount of calls.
Anecdotally:

  • before: 1m 27s and ctrl+f 520 returns 382 hits (so probably 191 errors as they are printed twice)
  • after: 0m 52s and ctrl+f 520 returns 256 hits (so probably 128 errors)

@felixfontein felixfontein merged commit 8b58498 into ansible-community:main Feb 1, 2021
@felixfontein felixfontein deleted the galaxy-page-size branch February 1, 2021 20:46
@felixfontein
Copy link
Collaborator Author

@dmsimard @abadger thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants