-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add period to end of new plugin statements in changelog #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
There are two aspects that should be changed:
- This behavior should be configurable (via the config file), so collections (and ansible-core) can opt-in to this behavior;
- The test for when to add
.
needs to be improved so it doesn't add periods after other punctuation; this can be done with... description.endswith((".", ",", "!", "?"))
;
Also this feature needs a changelog fragment :)
streamline the code (based on feedback) Co-authored-by: Felix Fontein <felix@fontein.de>
Doing an interim push up cuz I need help. It fails CI nox tests with KeyError modules at: Seems I've 'fixed it to death' and the changelog has no modules, but I'm not sure where my error is. |
still on the todo list:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also mention the new config file entry in docs/changelog-configuration.md.
Co-authored-by: Felix Fontein <felix@fontein.de>
@samccann thanks a lot for your contribution! :) |
Thanks for all the help! This was fun :-) |
Fixes #87