Remove Python version check #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotmax23
reviewed
Jun 3, 2024
|
Hmm. I can see the value of only maintaining the version in one location in source, but from a user perspective, if I just do a 'pip install antsibull-changelog' on a system with python 3.8 for example, it doesn't give me any errors. So if we remove the version check in this PR, how will I know it's not working (and why?). |
|
@samccann you'll likely get an older version then that still works with Python 3.8 :) Only with extremely old pip versions that didn't check for the Python version would you get the latest version, but then the Python is probably also very old and it would complain about syntax errors before running any code :) |
|
I rewrote the PR to remove the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was checking for Python 3.6, for which we dropped support quite some time ago (we're requiring Python 3.9+ since 2022-12-17).