Make CLI startup faster, support tab completion with argcomplete #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotmax23
reviewed
Aug 17, 2024
Co-authored-by: Maxwell G <maxwell@gtmx.me>
felixfontein
commented
Aug 17, 2024
Co-authored-by: Maxwell G <maxwell@gtmx.me>
|
Codecov gets less and less reliable and useful, it seems. I've started to mostly ignore it since it most of the time forgets some uploaded results and reports the wrong coverage number anyway. |
|
@gotmax23 thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically argcomplete support was already partially there, but the marker was missing to easily use it.
This also changes code to only import
ansibleandrstcheck/docutilswhen needed; this improves performance a lot (and thus makes tab complete less sluggy). On my machine, runningantsibull-changelog --helpsped up from ~0.6s to ~0.1s.