Port to sh v2 or ditch it entirely
#34
Comments
|
I'm currently tending to ditch |
|
(antsibull-core 2.x.y needs to keep |
|
I think I'll propose an |
|
There's also an async version of subprocess: https://docs.python.org/3/library/asyncio-subprocess.html This might be useful for some use-cases as well. |
gotmax23
added
the
antsibull-meta
This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does. Relates: ansible-community#34
This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does. Relates: ansible-community#34
This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does. Relates: ansible-community#34
This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does. Relates: ansible-community#34
This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does. Relates: ansible-community#34
This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does. Relates: ansible-community#34
This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does. Relates: ansible-community#34
* add subprocess_util module to replace sh This adds code to run subprocesses asynchronously and integrates with the logger. stdout and stderr are logged in real time and always captured. We return a CompletedProcess object like regular subprocess does. Relates: #34 * subprocess_util: also support stdlib Logger Both Logger classes have `.debug()`, `.info()`, etc. methods, so let's explicitly declare support for both. * subprocess_util: order arguments more logically * add unit tests for subprocess_util
|
We have merged
so we can close this, right? |
|
Not really, antsibull-core still needs to be depending on sh until 3.0.0 (for backwards compatibility with certain older antsibull/antsibull-docs releases). I would keep this open until then. |
Currently, we pin
shto>= 1.0.0 < 2.0.0, due to breaking changes. We should port antsibull to the new version or make our code compatible with both.(Another option would be to ditch it altogether and just use
subprocess.runor a helper function. I prefer to avoid extra dependencies when possible. Maybe sh is worth keeping, but I will note that it's not compatible with static analysis tools (we need to add pylint ignores every time) which causes some headache.))The text was updated successfully, but these errors were encountered: