Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pydantic v2 #92

Closed
gotmax23 opened this issue Jul 7, 2023 · 2 comments · Fixed by #122
Closed

Add support for pydantic v2 #92

gotmax23 opened this issue Jul 7, 2023 · 2 comments · Fixed by #122
Labels
antsibull-meta An issue that affects multiple antsibull projects dependencies Pull requests that update a dependency file

Comments

@gotmax23
Copy link
Collaborator

gotmax23 commented Jul 7, 2023

As of 03a2882, we restricted pydantic to v1. Now that pydantic v2 is GA, we should fix any incompats, relax this pin, and make sure to test with both versions in CI.

@gotmax23 gotmax23 added dependencies Pull requests that update a dependency file antsibull-meta An issue that affects multiple antsibull projects labels Jul 7, 2023
@felixfontein
Copy link
Collaborator

The migration guide will be helpful: https://docs.pydantic.dev/2.0/migration/

@gotmax23
Copy link
Collaborator Author

This shouldn't be too difficult, but we'll have to silence some DeprecationWarnings while we're still supporting pydantic v1. I'm not sure what to do about

extra: ContextDict = ContextDict()
though. The way pydantic v2 handles extra arguments is a bit different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
antsibull-meta An issue that affects multiple antsibull projects dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants