Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pydantic v2 support and drop v1 #122

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

gotmax23
Copy link
Collaborator

@gotmax23 gotmax23 commented Dec 1, 2023

pydantic v2 has a fair amount of API changes and deprecations that make simultaneously supporting it and v1 impractical. antsibull, antsibull-docs, and other dependent packages will require some small changes, as well.


Fixes: #92

@gotmax23 gotmax23 added this to the antsibull-core v3 milestone Dec 1, 2023
@gotmax23 gotmax23 closed this Dec 23, 2023
@gotmax23 gotmax23 reopened this Dec 23, 2023
pydantic v2 has a fair amount of API changes and deprecations that make
simultaneously supporting it and v1 impossible. antsibull,
antsibull-docs, and other dependent packages will require some small
changes, as well.
@gotmax23 gotmax23 marked this pull request as ready for review December 23, 2023 22:59
@gotmax23 gotmax23 changed the title [v3 DNM] add pydantic v2 support and drop v1 add pydantic v2 support and drop v1 Dec 23, 2023
@gotmax23 gotmax23 closed this Dec 23, 2023
@gotmax23 gotmax23 reopened this Dec 23, 2023
@gotmax23
Copy link
Collaborator Author

Ready for review

@felixfontein felixfontein merged commit ddf44c8 into ansible-community:main Dec 24, 2023
8 of 9 checks passed
@felixfontein
Copy link
Collaborator

@gotmax23 thanks! I'm really happy about this change :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for pydantic v2
2 participants