Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subprocess_util: support callbacks for stdout and stderr #113

Merged
merged 1 commit into from
Nov 29, 2023
Merged

subprocess_util: support callbacks for stdout and stderr #113

merged 1 commit into from
Nov 29, 2023

Conversation

gotmax23
Copy link
Collaborator

No description provided.

@gotmax23 gotmax23 force-pushed the subprocess_util_loopback branch from df59822 to fc6adef Compare November 21, 2023 04:49
felixfontein
felixfontein reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides this, LGTM!

src/antsibull_core/subprocess_util.py Show resolved Hide resolved
@gotmax23 gotmax23 force-pushed the subprocess_util_loopback branch from fc6adef to d207ec7 Compare November 28, 2023 22:48
@gotmax23 gotmax23 mentioned this pull request Nov 28, 2023
Merged
@gotmax23 gotmax23 added this to the antsibull-core 2.2.0 milestone Nov 29, 2023
@felixfontein felixfontein merged commit c6500c3 into ansible-community:main Nov 29, 2023
5 checks passed
@felixfontein
Copy link
Collaborator

@gotmax23 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gotmax23 @felixfontein