Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3] GalaxyClient: explicitly require a GalaxyContext #131

Merged
merged 1 commit into from
Jan 22, 2024
Merged

[v3] GalaxyClient: explicitly require a GalaxyContext #131

merged 1 commit into from
Jan 22, 2024

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Dec 24, 2023 •
edited
Loading

@felixfontein felixfontein changed the title GalaxyClient: explicitly require a GalaxyContext [v3] GalaxyClient: explicitly require a GalaxyContext Dec 24, 2023
@felixfontein felixfontein marked this pull request as draft December 24, 2023 11:58
@felixfontein felixfontein mentioned this pull request Dec 24, 2023
Closed
@gotmax23 gotmax23 added this to the antsibull-core v3 milestone Jan 21, 2024
@felixfontein
Copy link
Collaborator Author

Restarting CI.

@felixfontein felixfontein reopened this Jan 21, 2024
@felixfontein felixfontein marked this pull request as ready for review January 21, 2024 21:10
@felixfontein
Copy link
Collaborator Author

Failing CI will be fixed by ansible-community/ansible-build-data#353.

@felixfontein felixfontein requested a review from gotmax23 January 22, 2024 05:23
@felixfontein felixfontein merged commit d6a0b78 into ansible-community:main Jan 22, 2024
7 of 9 checks passed
@felixfontein felixfontein deleted the galaxyclient-constructor branch January 22, 2024 19:53
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
antsibull-core v3
Development

Successfully merging this pull request may close these issues.

[v3] Remove deprecated GalaxyClient contrstuctor default arguments
2 participants
@felixfontein @gotmax23