Accept ansible-core filename starting with ansible_core-<version>.tar as well; fix error message formatting
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
changed the title
ansible_core-<version>.tar as well; fix error message formatting
Code in antsibull relies on the top-level directory and the archive having the same basename.
felixfontein
added
the
backport-2
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #159 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
…r` as well; fix error message formatting (#158) * Fix error message formatting. * Accept filename starting with ansible_core as well. * AnsibleCorePyPiClient.retrieve: ensure the correct filename is returned Code in antsibull relies on the top-level directory and the archive having the same basename. * Update changelog. --------- Co-authored-by: Maxwell G <maxwell@gtmx.me> (cherry picked from commit d787b80)
gotmax23
added a commit
that referenced
this pull request
Apr 17, 2024
…r` as well; fix error message formatting (#158) (#159) * Fix error message formatting. * Accept filename starting with ansible_core as well. * AnsibleCorePyPiClient.retrieve: ensure the correct filename is returned Code in antsibull relies on the top-level directory and the archive having the same basename. * Update changelog. --------- (cherry picked from commit d787b80) Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Maxwell G <maxwell@gtmx.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ansible-core 2.16.6 the release filename is no longer
ansible-core-<version>.tar.gz, butansible_core-<version>.tar.gz.Also there was an
fmissing for the second line, causing the formatted error message to be something likeantsibull_core.ansible_core.UnknownVersion: ansible-core 2.16.6 does not exist on {self.pypi_server_url}.