-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing, use ClientTimeout instead of float, bump aiohttp dependency to 3.3.0+ #163
Conversation
antsibull compatibility fails because of pyre... |
Ping @gotmax23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dig through the aiohttp sources to verify the version constraints, but this looks good to me.
Backport to stable-2: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 87e294e on top of patchback/backports/stable-2/87e294e058f9edbf9d9cebfb0da6ede34b275e46/pr-163 Backporting merged PR #163 into main
🤖 @patchback |
@gotmax23 thanks for reviewing this! |
…cy to 3.3.0+ (ansible-community#163) * Fix typing problems pyre has with aiohttp 3.10.1. * Use ClientTimeout for timeout. * Fix aiohttp dependency. * Restrict aiohttp version for antsibull compatibility check to make pyre happy. (cherry picked from commit 87e294e)
Backport to stable-2: #164. |
I'm not sure whether there is an official deprecation, but the conversion code has been removed from
master
(aio-libs/aiohttp#6328) and there's now (since 3.10.0) typing that makes mypy no longer accept floats. The code in 3.10.0 still accepts them though, so this isn't a runtime issue yet.Also aiohttp 3.3.0+ is required for the timeout parameter that has been used by the GET retry manager since the beginning, so I updated the dependency version range.
Also pyre doesn't think
ClientSession.get
exists anymore with 3.10.0 🙄