Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use doc_parsing_backend from app_ctx and not lib_ctx #125

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein added the backport-1 Automatically create backport to stable-1 branch label Apr 16, 2023
@felixfontein felixfontein requested a review from gotmax23 April 16, 2023 12:50
@felixfontein
Copy link
Collaborator Author

(This passing CI before ansible-community/antsibull-core#59 is merged shows that this fix works as intended.)

@felixfontein
Copy link
Collaborator Author

This is showing yet another problem: the extra docsite building tests install Collecting antsibull-docs<2.0.0,>=1.0.0 (from -r requirements.txt (line 5))...

@felixfontein
Copy link
Collaborator Author

Restarting tests.

Copy link
Collaborator

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Thanks!

@gotmax23 gotmax23 merged commit 2fa17b6 into ansible-community:main Apr 16, 2023
@patchback
Copy link

patchback bot commented Apr 16, 2023

Backport to stable-1: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-1/2fa17b6122a8f09fc872e5772e0a1af1111d6bea/pr-125

Backported as #127

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 16, 2023
* Use doc_parsing_backend from app_ctx and not lib_ctx.

* Use app_ctx with right type.

(cherry picked from commit 2fa17b6)
@felixfontein felixfontein deleted the fix branch April 16, 2023 14:59
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing and merging!

felixfontein added a commit that referenced this pull request Apr 16, 2023
…p_ctx and not lib_ctx (#127)

* Use doc_parsing_backend from app_ctx and not lib_ctx (#125)

* Use doc_parsing_backend from app_ctx and not lib_ctx.

* Use app_ctx with right type.

(cherry picked from commit 2fa17b6)

* The lib context default is 'auto', not 'ansible-internal'.

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1 Automatically create backport to stable-1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants