Fix deprecations for plugins and role entrypoints #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection the role is removed from.
felixfontein
added
the
backport-1
briantist
approved these changes
Jun 8, 2023
tests/functional/baseline-default/collections/ns2/col/foo_become.rst
Outdated
Show resolved
Hide resolved
tests/functional/baseline-no-breadcrumbs/collections/ns2/col/foo_become.rst
Outdated
Show resolved
Hide resolved
tests/functional/baseline-no-indexes/collections/ns2/col/foo_become.rst
Outdated
Show resolved
Hide resolved
tests/functional/baseline-use-html-blobs/collections/ns2/col/foo_become.rst
Outdated
Show resolved
Hide resolved
tests/functional/collections/ansible_collections/ns2/col/plugins/become/foo.py
Outdated
Show resolved
Hide resolved
Backport to stable-1: 💚 backport PR created✅ Backport PR branch: Backported as #158 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
* Fix indent of 'Why' and 'Alternative' texts. * Add tests. * Allow role entrypoint deprecations without having to specify the collection the role is removed from. * Fix YAML. * Fix typo. Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> --------- Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> (cherry picked from commit 2d3c65e)
|
@briantist thanks a lot! |
felixfontein
added a commit
that referenced
this pull request
Jun 9, 2023
…d role entrypoints (#158) * Fix deprecations for plugins and role entrypoints (#156) * Fix indent of 'Why' and 'Alternative' texts. * Add tests. * Allow role entrypoint deprecations without having to specify the collection the role is removed from. * Fix YAML. * Fix typo. Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> --------- Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com> (cherry picked from commit 2d3c65e) * Ignore linting error. --------- Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed_from_collection(which is the collection the role is part of anyway).