Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect finding and alias reporting #183

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

felixfontein
Copy link
Collaborator

Ref: ansible/ansible#81148

Now scan ansible-core for symlinks to avoid problems with editable installs. Also make sure that duplicates are removed when non-editable installs are used: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/ has both systemd and systemd_service listed as separate modules.

@felixfontein felixfontein merged commit 3001711 into ansible-community:main Jun 29, 2023
@felixfontein felixfontein deleted the redirects branch June 29, 2023 11:15
@felixfontein felixfontein added the backport-1 Automatically create backport to stable-1 branch label Jun 29, 2023
@patchback
Copy link

patchback bot commented Jun 29, 2023

Backport to stable-1: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 3001711 on top of patchback/backports/stable-1/3001711cda16c43fb9cdb13bf9d1eae0431cee4e/pr-183

Backporting merged PR #183 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-community/antsibull-docs.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-1/3001711cda16c43fb9cdb13bf9d1eae0431cee4e/pr-183 upstream/stable-1
  4. Now, cherry-pick PR Fix redirect finding and alias reporting #183 contents into that branch:
    $ git cherry-pick -x 3001711cda16c43fb9cdb13bf9d1eae0431cee4e
    If it'll yell at you with something like fatal: Commit 3001711cda16c43fb9cdb13bf9d1eae0431cee4e is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 3001711cda16c43fb9cdb13bf9d1eae0431cee4e
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix redirect finding and alias reporting #183 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-1/3001711cda16c43fb9cdb13bf9d1eae0431cee4e/pr-183
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1 Automatically create backport to stable-1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant