Deprecate --use-html-blobs #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantist
reviewed
Sep 17, 2023
|
I would print these warnings to |
|
that is a good point, why not use |
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
I just tried that, the result was that the warning isn't printed. |
briantist
approved these changes
Sep 18, 2023
|
(I didn't spend much time trying to figure out why the warnings don't show... But I guess doing it this way also works, since these parts aren't used - or shouldn't be used - as Python libraries.) |
|
@briantist @gotmax23 thanks a lot for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is causing more and more problems, in particular now that it's so easy to reference options and return values (which simply won't work when this feature is enabled).
It is possible to make it work, but it's quite some amount of work, and I'm convinced that this isn't really needed.
(HTML tables are still a thing for the
simplified-rstoutput format and won't go away there.)