Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further requirements note #24

Merged

Conversation

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on little nit. Clever approach!!

src/antsibull_docs/data/docsite/plugin.rst.j2 Outdated Show resolved Hide resolved
Co-authored-by: Sandra McCann <samccann@redhat.com>
@felixfontein
Copy link
Collaborator Author

(The links are updated with the latest version of this PR.)

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't judge the code but the output LGTM!

@felixfontein felixfontein merged commit 1eeefc0 into ansible-community:main Aug 16, 2022
@felixfontein felixfontein deleted the further-requirements branch August 16, 2022 20:22
@felixfontein
Copy link
Collaborator Author

@samccann thanks a lot for testing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection note should indicate that further dependencies may be required.
2 participants