Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module/role level version_added rendering #41

Merged
merged 3 commits into from
Sep 25, 2022

Conversation

felixfontein
Copy link
Collaborator

@felixfontein
Copy link
Collaborator Author

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@felixfontein felixfontein merged commit 0e797d4 into ansible-community:main Sep 25, 2022
@felixfontein felixfontein deleted the version-added branch September 25, 2022 14:36
@felixfontein
Copy link
Collaborator Author

@briantist thanks for reviewing this!

@samccann
Copy link
Contributor

fwiw, it used to say;
New in version 2.5.0: of community.hashi_vault
And now it says:
New in version community.hashi_vault: 2.5.0

I prefer the older way of putting the version first. Do we know why it changed?

@felixfontein
Copy link
Collaborator Author

@samccann this was changed in #34, not in this PR. The main reason this change happened was because all other version added texts were bad. That this one changed in this way wasn't intentional.

@felixfontein
Copy link
Collaborator Author

felixfontein commented Sep 26, 2022

In any case, New in version 2.5.0: of community.hashi_vault isn't great either, since this basically says (using Sphinx's semantics) that the feature called "of community.hashi_vault" was added in version 2.5.0.

@samccann
Copy link
Contributor

ok thanks for the explanation. What do you think about New in community.foo: version 2.4.0 as an enhancement in the future?

@felixfontein
Copy link
Collaborator Author

@felixfontein
Copy link
Collaborator Author

(I created #43 for this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants