-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix module/role level version_added rendering #41
Fix module/role level version_added rendering #41
Conversation
You can see the improved output here: https://ansible.fontein.de/collections/community/hashi_vault/vault_kv2_get_module.html#ansible-collections-community-hashi-vault-vault-kv2-get-module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
@briantist thanks for reviewing this! |
fwiw, it used to say; I prefer the older way of putting the version first. Do we know why it changed? |
In any case, |
ok thanks for the explanation. What do you think about |
@samccann what do you think about |
(I created #43 for this.) |
There
_
is escaped and the escaping is visible in the rendered HTML, see for example https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/vault_kv2_get_module.html, https://docs.ansible.com/ansible/devel/collections/community/sap_libs/sap_snote_module.html, and https://docs.ansible.com/ansible/devel/collections/cloudscale_ch/cloud/network_module.html.Thanks to @briantist for noticing and reporting this on IRC.