Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

0.3.4(yanked): regression config expansion no longer happens #57

Closed
ssbarnea opened this issue May 25, 2021 · 3 comments
Closed

0.3.4(yanked): regression config expansion no longer happens #57

ssbarnea opened this issue May 25, 2021 · 3 comments
Assignees
Labels
bug This issue/PR relates to a bug.

Comments

@ssbarnea
Copy link
Member

ssbarnea commented May 25, 2021

Apparently last release no longer works with configuration items that have expansions as they endup being used directly:

  msg: 'Error pulling image molecule_local/${MOLECULE_IMAGE:-centos:7} - 400 Client Error for http+docker://ssh/v1.41/images/create?tag=7%7D&fromImage=molecule_local%2F%24%7BMOLECULE_IMAGE: Bad Request ("invalid reference format: repository name must be lowercase")'

The previous one 0.3.3 does not have the same bug. Until we fix it, please add molecule-docker!=0.3.4 to your dependencies.

Initially reported by @arxcruz

@ssbarnea ssbarnea self-assigned this May 25, 2021
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label May 25, 2021
@ssbarnea
Copy link
Member Author

Bisecting I was able to identify that this regression was introduced by #51

rdoproject pushed a commit to rdo-infra/review.rdoproject.org-config that referenced this issue May 25, 2021
Latest release of molecule-docker breaks [1] pinning to not use the
latest version.

1 - ansible-community/molecule-docker#57

Closes-Bug: #1929551
Change-Id: I0a196e88b9182ec2d006ffce90b3d30993012c28
@ssbarnea
Copy link
Member Author

Apparently there are other issues with newer release. I seen error below with ansible 2.9.22, which was not expected:

msg: the connection plugin 'community.docker.docker' was not found

That is caused by #56 as 'community.docker is not installed by it

The big question is if we want to enforce use of 'community.docker collection or if we want to fallback to the older docker module included with ansible 2.9

For that second problem the workaround is to run ansible-galaxy collection install community.docker

@ssbarnea
Copy link
Member Author

I yanked 0.3.4 release and due to the huge number of changes needed the next release will be 0.4.0 and we will not make any fixes to the current one (being unable to test them correctly).

@ssbarnea ssbarnea changed the title 0.3.4: regression config expansion no longer happens 0.3.4(yanked): regression config expansion no longer happens May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant