Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding python-vagrant as dep to vagrant plugin #133

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Adding python-vagrant as dep to vagrant plugin #133

merged 1 commit into from
Apr 21, 2023

Conversation

carlosmmatos
Copy link
Contributor

Fixes #132

@apatard
Copy link
Member

apatard commented Apr 21, 2023

thanks for noticing it. I had a similar change and forgot to send it. I had also ansible-core. @ssbarnea, do you think we should have ansible-core here or this PR is fine ?

@ssbarnea ssbarnea added the bug Something isn't working label Apr 21, 2023
@ssbarnea ssbarnea enabled auto-merge (squash) April 21, 2023 09:16
@ssbarnea ssbarnea merged commit 7498e81 into ansible-community:main Apr 21, 2023
@ssbarnea
Copy link
Member

@apatard no real need to add ansible-core because it is already included by the dependency on molecule itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip install 'molecule-plugins[vagrant]' - does not work as intended
3 participants
@carlosmmatos @apatard @ssbarnea