podman: change ansible_async_dir only when $HOME is redefined #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcancelliere
force-pushed
the
avoid-hardcoding-ansible-async-dir
branch
7 times, most recently
from
e7a5500 to
6729ec0
Compare
grcancelliere
force-pushed
the
avoid-hardcoding-ansible-async-dir
branch
from
6729ec0 to
99912cd
Compare
grcancelliere
force-pushed
the
avoid-hardcoding-ansible-async-dir
branch
from
99912cd to
1a3f276
Compare
- src/molecule_plugins/podman/playbooks: reworked the ansible_async_dir logic: - use ansible.builtin.getent to get the passwd information for $USER - use the ansible.builtin.config lookup to get the async_dir information - set ansible_async_dir by rewriting the home folder only if the two home paths are different - tox.ini: add USER to the pass_env list, since the new ansible_async_dir logic relies on looking up the equivalent of getent passwd $USER
grcancelliere
force-pushed
the
avoid-hardcoding-ansible-async-dir
branch
from
1a3f276 to
81296ca
Compare
audgirka
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #73
This PR tries to avoid the hardcoding of
ansible_async_dirintroduced in molecule-podman PR #139 by usingansible.builtin.getentto get the$USERpasswd data and by usingansible.builtin.configto getasync_dirfrom the shell configuration.ansible_async_dirwill be set only if the two home paths are different and the value will pick up the changes set from the rest of the controller set-up.tox.iniis also updated to allowlookup('env', 'USER')to work in the CI.