This repository has been archived by the owner on Jan 8, 2023. It is now read-only.
Fixing podman flags order sequence in create task #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes moves the podman flags: `--storage-opt`, `--storage-driver` and `--cgroup-manager` to be called before the `run` command. This fix a execution fail when using some of those flags in the `molecule.yml` file. e.g: this: ```bash podman --cgroup-manager=cgroupfs --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs --storage-driver=overlay run -d --name node.local --privileged=True --volume /dev/fuse:/dev/fuse:rw --tmpfs=/run --tmpfs=/tmp --hostname=node.local docker.io/pycontribs/centos:8 /sbin/init ``` instead of this: ```bash podman run -d --name node.local --privileged=True --volume /dev/fuse:/dev/fuse:rw --tmpfs=/run --tmpfs=/tmp --hostname=node.local --cgroup-manager=cgroupfs --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs --storage-driver=overlay docker.io/pycontribs/centos:8 /sbin/init ```
sshnaidm
approved these changes
Jun 2, 2021
|
I've converted back to draft by mistake, is there anything expected from me regarding the CI pending status? Or I can just wait? Please let me know, cheers |
sshnaidm
approved these changes
Jun 3, 2021
ssbarnea
approved these changes
Jun 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes moves the podman flags:
--storage-opt,--storage-driverand--cgroup-managerto be calledbefore the
runcommand.This fix a execution fail when using some of those flags in the
molecule.ymlfile.e.g:
this:
instead of this: