- Fixed handler name typo

[MarcoV-git]

• Added protection for skipped resultset items
• Made when statement layout consistent

Overall Review of Changes:
A general description of the changes made that are being requested for merge

Issue Fixes:
Please list (using linking) any open issues this PR addresses

Enhancements:
Please list any enhancements/features that are not open issue tickets

How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A

[github-actions]

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

[uk-bolly]

Great catch on these items thank you

[uk-bolly]

Hi @MarcoV-git

Great catch on finding these issues and supplying the fix. I have noted that the signed-off-by part is missing from the signing commits that we require.
If you could please add that am happy to accept and merge this request.

Many thanks

uk-bolly

[github-actions]

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

[MarcoV-git]

@uk-bolly ,

My commit has been signed. There's an unsigned commit from you:

commit c82d920 (HEAD -> devel, origin/devel, origin/HEAD)
Author: Marco V marco@osp.nl
Date: Fri Jul 21 11:04:00 2023 +0200

- Fixed handler name typo
- Added protection for skipped resultset items
- Made when statement layout consistent

Signed-off-by: Marco V <marco@osp.nl>

commit 36f35d0
Merge: f37b8e2 f11d34f
Author: uk-bolly mark.bollyuk@gmail.com
Date: Tue Jul 18 15:25:38 2023 +0100

Merge pull request #302 from ansible-lockdown/tidy

Tidy up and linting

[uk-bolly]

@uk-bolly ,

My commit has been signed. There's an unsigned commit from you:

commit c82d920 (HEAD -> devel, origin/devel, origin/HEAD) Author: Marco V marco@osp.nl Date: Fri Jul 21 11:04:00 2023 +0200

- Fixed handler name typo
- Added protection for skipped resultset items
- Made when statement layout consistent

Signed-off-by: Marco V <marco@osp.nl>

commit 36f35d0 Merge: f37b8e2 f11d34f Author: uk-bolly mark.bollyuk@gmail.com Date: Tue Jul 18 15:25:38 2023 +0100

Merge pull request #302 from ansible-lockdown/tidy

Tidy up and linting

hi @MarcoV-git

Apologies for the confusion, I can see it is signed-off i meant to say gpg signed.
A merge commit is a slightly different commit and wouldn't be signed in the same fashion as i was confirming the mergings of other content changes which are both gpg and signed-off by.
The easiest way i have found with github is if you look at the PR and the commits tabs you will see a "verified" icon when it has been GPG signed.
I have looked for a better way to add that test to the pipeline but as yet have not found it as DCO only does half the job.

I hope that makes sense and thank you once again for your time and continuing to follow up.

kindest regards

uk-bolly

[MarcoV-git]

@uk-bolly Finally fixed the pull

[uk-bolly]

Great work thank you

[bbaassssiiee]

This PR caused CI failure, see issue #306