Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit - workflow update #309

Merged
merged 24 commits into from
Aug 8, 2023
Merged

Pre-commit - workflow update #309

merged 24 commits into from
Aug 8, 2023

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Aug 4, 2023

Overall Review of Changes:
Added ability for pre-commit
new workflow using remote repo for IaC requirements
README
Issue Fixes:
#306

Enhancements:
Workflow

  • separate workflwo for main and devel
  • relevant badges and lables updated in readme
  • remote IaC code for execution

pre-commit

  • including secrets checking
  • linting

How has this been tested?:
Manually and pipeline

uk-bolly added 18 commits July 4, 2023 14:16
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Bugfix/306 - precommit not currently there expected failures
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
Copy link
Member Author

uk-bolly commented Aug 4, 2023

Pipeline run twice

  1. First run commit with workflow files still embedded to test code
  2. Second run commit legacy files for workflow no longer present.

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly requested a review from MrSteve81 August 4, 2023 11:46
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved And Nice work

@uk-bolly uk-bolly merged commit 38db099 into devel Aug 8, 2023
@uk-bolly uk-bolly deleted the pre-commit branch August 8, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants