Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #16

Merged
merged 6 commits into from
May 17, 2022
Merged

Improvements #16

merged 6 commits into from
May 17, 2022

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:

  • Tidy up Warning msg and some conditional msgs
  • Remove Legacy checks no longer required for python2 and older OS release checks

How has this been tested?:

Tested manually

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly uk-bolly requested a review from georgenalen May 11, 2022 10:24
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@uk-bolly uk-bolly marked this pull request as ready for review May 11, 2022 12:27
@uk-bolly uk-bolly merged commit 0212c6a into devel May 17, 2022
@uk-bolly uk-bolly deleted the improvements branch May 17, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants