Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue audit updates #221

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Issue audit updates #221

merged 6 commits into from
Jul 17, 2024

Conversation

uk-bolly
Copy link
Member

Overall Review of Changes:
Issues addressed
changed to audit
removal of jmespath requirement
updated workflow

Issue Fixes:
thanks to @tedunder237
#216
#217

Enhancements:
Updated the way the audit summary is captured
removed the jmespath dependancy across the playbook
new workflow files added

How has this been tested?:
Manually

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
georgenalen
georgenalen previously approved these changes Jul 12, 2024
Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
@uk-bolly
Copy link
Member Author

pipeline will fail due to change and password default.
will work with new pipeline

Copy link
Contributor

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@uk-bolly uk-bolly merged commit dbbe8a9 into devel Jul 17, 2024
3 of 4 checks passed
@uk-bolly uk-bolly deleted the issue_audit_updates branch July 17, 2024 07:01
@uk-bolly
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants