Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sept23 to devel #93

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Sept23 to devel #93

merged 8 commits into from
Sep 13, 2023

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Sep 6, 2023

Overall Review of Changes:
Outstanding issues and PRs

Issue Fixes:

Enhancements:
The use of ansible_facts as per #54

How has this been tested?:
Manually and pipeline

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
MrSteve81
MrSteve81 previously approved these changes Sep 6, 2023
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@uk-bolly uk-bolly merged commit 18a44fc into devel Sep 13, 2023
3 checks passed
@uk-bolly uk-bolly deleted the sept23 branch September 13, 2023 13:32
@uk-bolly uk-bolly mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants