handle release_summary from config #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NilashishC
reviewed
Jun 6, 2024
| @@ -125,6 +125,8 @@ def is_valid_changelog_format(path: str) -> bool: | |||
| changelog_config = yaml.safe_load(config_file) | |||
| changes_type = tuple(item[0] for item in changelog_config["sections"]) | |||
| changes_type += (changelog_config["trivial_section_name"],) | |||
| changes_type += (changelog_config["prelude_section_name"],) | |||
| changes_type += (changelog_config["new_plugins_after_name"],) | |||
There was a problem hiding this comment.
Well, I mean I kinda get what it's doing, I just don't understand the key name here. Might be beyond the scope of this PR though.
There was a problem hiding this comment.
That is correct, I am not sure what section should be prelude_section_name
I'll take it out!
There was a problem hiding this comment.
If you take prelude section name out, it wouldn't recognize release_summary.
There was a problem hiding this comment.
@NilashishC My bad, removed new_plugins_after_name now, confused it with prelude_section_name while removing did not check config.yml 😿
NilashishC
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.