Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail if init-path exists but is empty #134

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

NilashishC
Copy link
Collaborator

@NilashishC NilashishC commented Apr 8, 2024

With v24.4.0, creator erroneously raises an error even if the final init-path exists but is empty. It should only complain when the init-path is non-empty and --force is disabled.

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC added the bug Something isn't working label Apr 8, 2024
@NilashishC NilashishC requested a review from a team as a code owner April 8, 2024 18:35
@NilashishC NilashishC requested review from ssbarnea and Qalthos and removed request for a team April 8, 2024 18:35
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove test log file.

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Copy link
Collaborator Author

Remove test log file.

Fixed.

@ssbarnea ssbarnea merged commit 965325c into ansible:main Apr 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants