-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not fail if init-path
exists but is empty
#134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
NilashishC
requested review from
ssbarnea and
Qalthos
and removed request for
a team
April 8, 2024 18:35
ssbarnea
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove test log file.
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
ssbarnea
force-pushed
the
fix_init_path_1
branch
from
April 8, 2024 18:53
075265e
to
7a9d99a
Compare
NilashishC
force-pushed
the
fix_init_path_1
branch
from
April 8, 2024 18:54
7a9d99a
to
3f7b68b
Compare
Fixed. |
ssbarnea
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With v24.4.0, creator erroneously raises an error even if the final
init-path
exists but is empty. It should only complain when theinit-path
is non-empty and--force
is disabled.