Improve collection root detection #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cidrblock
requested review from
priyamsahoo and
shatakshiiii
and removed request for
a team
anshulbehl
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the integration test role, use the
MOLECULE_PROJECT_DIRECTORYset for the parent process.The collection root will be the parent directory of the extensions directory which is considered the MOLECULE_PROJECT_DIRECTORY.
This will also eliminate the need to
git initthe collection root for the sake of molecule prior to developing tests.Note- The vars file name was reverted to
'.ymlfrom.j2b/c there was no templating required of the file at this time.Note: Templating will be limited to those files that have a
.j2suffix to avoid a double templating issue where a filter plugin may belong to ansible. We are only using the jinja2 library for templating so ansible's plugins are not available. Several file that needed to be templated were missing the.j2extension.Thinking aloud, it might be nice to have the j2 somewhere else in the file, or in a header so we get native sytax checking for the real filetype