Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use project specific name in devfile #280

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Use project specific name in devfile #280

merged 5 commits into from
Aug 22, 2024

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii added the enhancement New feature or request label Aug 19, 2024
@shatakshiiii shatakshiiii self-assigned this Aug 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@shatakshiiii shatakshiiii marked this pull request as ready for review August 22, 2024 10:00
@shatakshiiii shatakshiiii requested a review from a team as a code owner August 22, 2024 10:00
@shatakshiiii shatakshiiii requested review from tima, Qalthos, cidrblock and a team and removed request for a team August 22, 2024 10:00
audgirka
audgirka approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@audgirka audgirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KB-perByte
Copy link
Member

Thanks for working on this @shatakshiiii

cidrblock
cidrblock approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@cidrblock cidrblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thx.....

Nice work keeping the ocverage at 100% :)

@shatakshiiii shatakshiiii merged commit c8714db into ansible:main Aug 22, 2024
17 checks passed
@shatakshiiii shatakshiiii deleted the devfile_name branch August 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KB-perByte KB-perByte KB-perByte approved these changes

@cidrblock cidrblock cidrblock approved these changes

@audgirka audgirka audgirka approved these changes

@tima tima Awaiting requested review from tima tima is a code owner automatically assigned from ansible/devtools

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

Assignees

@shatakshiiii shatakshiiii

Labels
enhancement New feature or request
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFE: Project specific name in devfile
4 participants
@shatakshiiii @KB-perByte @audgirka @cidrblock