Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop docs/docsite/requirements.txt #255

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Aug 8, 2023

This PR resolves #107 and is a follow up on #60 and #271

Remove docs/docsite/requirements.txt in favor of the relaxed requirements file.

@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Aug 8, 2023
@oraNod
Copy link
Contributor Author

oraNod commented Aug 8, 2023

I've been wrangling with this one a little more and thought I'd just send a PR and ask. Hopefully this is a sensible way to provide the equivalent of docs/docsite/requirements.txt (allowing the ability to test different packages and versions on the devel branch).

It seems there might be two ways to go about this.

  1. Either install requirements.in or requirements-devel.in.
  2. Install requirements.in and then requirements-devel.in on top of the main dependencies.

Option two should make it possible to reduce requirements-devel.in down to two packages: sphinx-intl and pygments.

tests/constraints-devel.in Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

webknjaz commented Aug 8, 2023

2. Install `requirements.in` and then `requirements-devel.in` on top of the main dependencies.

It must be a single command or, alternatively, both commands need two -c so that the constraints remain the same.
If you run one, then the other, then, being generated separately, they may have different versions pinned and the second one may upgrade, or downgrade dependencies installed by the first one.

Option two should make it possible to reduce requirements-devel.in down to two packages: sphinx-intl and pygments.

Try adding -r requirements.in to requirements-devel.in.

@oraNod oraNod force-pushed the issue-107/devel-requirements branch from ea840f0 to ade6ad0 Compare August 8, 2023 15:11
tests/constraints.in Outdated Show resolved Hide resolved
tests/requirements-devel.in Outdated Show resolved Hide resolved
@oraNod oraNod force-pushed the issue-107/devel-requirements branch from ade6ad0 to 1bdd2f8 Compare August 9, 2023 08:31
@oraNod oraNod requested review from webknjaz and felixfontein August 9, 2023 08:32
@oraNod oraNod mentioned this pull request Aug 9, 2023
@oraNod oraNod added doc builds Relates to building the documentation and removed needs_triage Needs a first human triage before being processed. labels Aug 9, 2023
tests/requirements.txt Outdated Show resolved Hide resolved
@oraNod oraNod force-pushed the issue-107/devel-requirements branch from 1bdd2f8 to 3f3427e Compare August 9, 2023 14:12
@oraNod oraNod force-pushed the issue-107/devel-requirements branch from 3f3427e to 6b27bff Compare August 9, 2023 15:02
@oraNod oraNod changed the title pin devel build requirements Drop docs/docsite/requirements.txt Aug 21, 2023
@oraNod oraNod force-pushed the issue-107/devel-requirements branch 2 times, most recently from f3f398e to 892de06 Compare August 21, 2023 09:46
@oraNod oraNod force-pushed the issue-107/devel-requirements branch from 892de06 to f91e857 Compare August 23, 2023 11:49
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Jenkins build that the docs build w/o this file.

@oraNod oraNod requested a review from webknjaz August 24, 2023 08:46
@samccann samccann merged commit 4be6802 into ansible:devel Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc builds Relates to building the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit docs/docsite/requirements.txt
4 participants