Remove fallback for modules/plugins in ansible/ansible that didn't work since ansible-base/Ansible 2.10 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk since ansible-base/Ansible 2.10.
|
@felixfontein This looks like it works to me. I deployed to the test site: http://docs.testing.ansible.com/ansible/devel/index.html According to the getting started page that @Andersson007 pointed out in #33 I can see the Edit on GitHub link:
|
|
@oraNod thanks for testing and reviewing this! |
felixfontein
added a commit
to felixfontein/ansible-documentation
that referenced
this pull request
Jul 4, 2023
…rk since ansible-base/Ansible 2.10. (ansible#42) (cherry picked from commit ddecebb)
This was referenced Jul 4, 2023
Merged
|
@felixfontein thanks for fixing this! @oraNod thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first part of #33. This case right now mainly prevents that some pages have an Edit on GitHub link. All plugin/module/role pages are covered by the
if check_meta and 'github_url' in meta(ansibull-docs includesgithub_urlin the page's meta if it can figure the URL out) and{% elif pagename.startswith('collections/') %}cases.