Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallowed-ignore[sanity]: disallow specific skips in ignore files #2121

Closed
thedoubl3j opened this issue May 11, 2022 · 5 comments · Fixed by #3102
Closed

disallowed-ignore[sanity]: disallow specific skips in ignore files #2121

thedoubl3j opened this issue May 11, 2022 · 5 comments · Fixed by #3102
Labels
AAP Ansible Automation Platform enhancement new rule A request for a new rule
Milestone

Comments

@thedoubl3j
Copy link
Member

filter/read ignore file and compare against a static/hardcoded list of tests that are allowed to be skipped.

example of allowed skip: validate-modules:missing-gplv3-license as AAP allows more than gpl licensing for collections

@thedoubl3j thedoubl3j added enhancement AAP Ansible Automation Platform new rule A request for a new rule labels May 11, 2022
@cidrblock
Copy link
Contributor

This is most likely a candidate for certified/validated content headed to AH........

@ssbarnea
Copy link
Member

We want to allow some rules to declare themselves unskippable when run in strict mode, strict mode is always use by validators.

@ssbarnea ssbarnea removed the new rule A request for a new rule label Jul 20, 2022
@ssbarnea ssbarnea changed the title new rule: enforce a specific list of tests allowed to be skipped in ignore files Enforce a specific list of tests allowed to be skipped in ignore files Jul 20, 2022
@cidrblock
Copy link
Contributor

The goal here is to look inside the ansible-test ignore file and ensure certain things are not being skipped e.g. this file: https://github.com/ansible-collections/cisco.nxos/blob/main/tests/sanity/ignore-2.10.txt

@ssbarnea ssbarnea changed the title Enforce a specific list of tests allowed to be skipped in ignore files disallowed-ignore[sanity]: disallow specific skips in ignore files Jul 20, 2022
@ssbarnea ssbarnea added enhancement new rule A request for a new rule and removed enhancement labels Jul 20, 2022
@ssbarnea ssbarnea added this to the 6.9.x milestone Oct 1, 2022
@MarkusTeufelberger
Copy link
Contributor

This is really annoying if there are bugs within Ansible that concern sanity tests. Concretely in my case: ansible/ansible#76612

The issue in ansible/ansible got closed by a bot, there still is an open PR (ansible/ansible#79700) that's unreviewed for months (the bug has been reported for years now) and this new rule means I need to add some ignores (how do I do that actually?) for this rule to my ignore-files or globally ignore this rule completely until the bug in Ansible itself that requires the disallowed ignore is fixed and backported.

Please advise how to disable this check for single lines in a sanity ignore file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AAP Ansible Automation Platform enhancement new rule A request for a new rule
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants