-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disallowed-ignore[sanity]: disallow specific skips in ignore files #2121
Comments
This is most likely a candidate for certified/validated content headed to AH........ |
We want to allow some rules to declare themselves unskippable when run in strict mode, strict mode is always use by validators. |
The goal here is to look inside the ansible-test ignore file and ensure certain things are not being skipped e.g. this file: https://github.com/ansible-collections/cisco.nxos/blob/main/tests/sanity/ignore-2.10.txt |
This is really annoying if there are bugs within Ansible that concern sanity tests. Concretely in my case: ansible/ansible#76612 The issue in ansible/ansible got closed by a bot, there still is an open PR (ansible/ansible#79700) that's unreviewed for months (the bug has been reported for years now) and this new rule means I need to add some ignores (how do I do that actually?) for this rule to my ignore-files or globally ignore this rule completely until the bug in Ansible itself that requires the disallowed ignore is fixed and backported. Please advise how to disable this check for single lines in a sanity ignore file. |
filter/read ignore file and compare against a static/hardcoded list of tests that are allowed to be skipped.
example of allowed skip:
validate-modules:missing-gplv3-license
as AAP allows more than gpl licensing for collectionsThe text was updated successfully, but these errors were encountered: