-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sanity rule with check for bad and disallowed ignores #3102
Conversation
Note: The |
dd4645a
to
da1828b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and what we want to enforce from a certification stand point.
a843ad7
to
c07c0fd
Compare
c07c0fd
to
acff058
Compare
Eco pipeline is correctly failing as cisco.nxos collection will need some updates. |
I'm going to open another PR today adding allow-lists for specific versions of ansible. E.g. |
The old ignore file ignore-2.12.txt is not needed and used anymore. The new files ignore-2.13.txt and ignore-2.14.txt are empty after ansible-lint made nearly all ignores disallowed. All the newly disallowed ignores need to be fixed. See ansible/ansible-lint#3102
The old ignore file ignore-2.12.txt is not needed and used anymore. The new files ignore-2.13.txt and ignore-2.14.txt are empty after ansible-lint made nearly all ignores disallowed. All the newly disallowed ignores need to be fixed. See ansible/ansible-lint#3102
Note: This is an extremely opinionated rule that Partner Engineering enforces for certified content.
New rule sanity checks the
tests/sanity/ignore-x.x.txt
files for disallowed ignores. Commented-out entries are not evaluated.Currently (broadly) allowed ignores are:
validate-modules:missing-gplv3-license
import-2.6
import-2.6!skip
import-2.7
import-2.7!skip
import-3.5
import-3.5!skip
compile-2.6
compile-2.6!skip
compile-2.7
compile-2.7!skip
compile-3.5
compile-3.5!skip
Error breakdown:
sanity[cannot-ignore]
- Ignore file contains a test that is not on the allow list.sanity[bad-ignore]
- Ignore file entry is formatted incorrectly.Other changes:
sanity-ignore-file
to recognize files with glob patterntests/sanity/ignore*.txt
sanity.py
production
profileFixes: #2121