Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code compatible with rich 11 #1797

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Make code compatible with rich 11 #1797

merged 1 commit into from
Jan 10, 2022

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Jan 10, 2022 •
edited by tadeboro
Loading

This has been dropped in rich 11.0.0.

Fixes #1795

@rabi rabi requested a review from a team as a code owner January 10, 2022 03:53
@rabi rabi requested review from relrod, cidrblock and priyamsahoo and removed request for a team January 10, 2022 03:53
@rabi rabi mentioned this pull request Jan 10, 2022
Closed
tadeboro
tadeboro suggested changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the general idea of making sure the linter works with the latest stable version of rich. But I am not 100% sold on raising the required rich version at this point since the version that introduced incompatibility is only four months old.

setup.cfg Outdated Show resolved Hide resolved
src/ansiblelint/generate_docs.py Outdated Show resolved Hide resolved
@tadeboro tadeboro added the bug label Jan 10, 2022
@rabi
Replace render_group usage
e41e9b5 
This has been dropped in rich 11.0.0.
tadeboro
tadeboro approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rabi, for your contribution!

@ssbarnea ssbarnea changed the title Replace render_group usage Make code compatible with rich 11 Jan 10, 2022
@ssbarnea ssbarnea merged commit 9465a23 into ansible:main Jan 10, 2022
@keith-turner keith-turner mentioned this pull request Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronraimist aaronraimist aaronraimist left review comments

@ssbarnea ssbarnea ssbarnea approved these changes

@tadeboro tadeboro tadeboro approved these changes

@relrod relrod Awaiting requested review from relrod relrod was automatically assigned from ansible-community/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock was automatically assigned from ansible-community/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo was automatically assigned from ansible-community/devtools

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'render_group' from 'rich.console'
4 participants
@rabi @tadeboro @ssbarnea @aaronraimist