Add tool to generate formatting fixtures #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
force-pushed
the
generate-formatting-fixtures
branch
from
f6338ea to
725be20
Compare
|
aargh. galaxy seems to be on the fritz. |
|
Consider implementing this as a pytest plugin activated by a custom CLI option. |
|
@webknjaz done. I converted it to a "test" + pytest plugin. If |
ssbarnea
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
OK. I made a fix myself to keep using "after" in naming of formatting fixtures as we should not use implementation detail in them.
Keep in mind that we might start to format something else than yaml or to swap for another yaml library. The fact that we use ruamel-yaml is an implementation detail.
|
Works for me. Thanks for reviewing! |
This was referenced Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tools/generate-formatting-fixtures.py which uses prettier to generate the fixture files.
Rename test/fixtures/formatting-after -> test/fixtures/formatting-prettier.
Add new test/fixtures/formatting-ruamel-yaml which is a copy of the prettier files for now.
In #1927, the diff will show where our ruamel.yaml formatter differs from prettier.
Also, add new fmt-2.yml formatting test fixture to cover a few more yaml oddities.