Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JSON Schema verification for several known file types #2035

Merged
merged 2 commits into from
May 10, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Mar 22, 2022

Adds initial schema validation for most known file types with the exception of tasks and playbook, mainly due to a bug in jsonschema library.

This adds a new runtime dependency, jsonschema, but that is of no concerns for AAP because ansible-navigator 2.0 is already listing it as a dependency.

Related: python-jsonschema/jsonschema#931

@ssbarnea ssbarnea self-assigned this Mar 22, 2022
@ssbarnea ssbarnea force-pushed the feature/jsonschema branch from a470fbb to e22324c Compare March 22, 2022 18:12
@ssbarnea ssbarnea changed the title feature/jsonschema WIP Implement JSON Schema verification for known file types Mar 22, 2022
@github-actions github-actions bot added the skip-changelog Can be missed from the changelog. label Mar 22, 2022
@ssbarnea ssbarnea force-pushed the feature/jsonschema branch from e22324c to 021648f Compare April 29, 2022 12:05
@ssbarnea ssbarnea changed the title WIP Implement JSON Schema verification for known file types Implement JSON Schema verification for several known file types Apr 29, 2022
@ssbarnea ssbarnea force-pushed the feature/jsonschema branch 2 times, most recently from 9512e40 to 807a798 Compare April 29, 2022 13:40
@ssbarnea ssbarnea requested a review from cidrblock April 29, 2022 13:40
ssbarnea added a commit to ssbarnea/schemas that referenced this pull request Apr 29, 2022
@ssbarnea ssbarnea force-pushed the feature/jsonschema branch from 807a798 to aee5ef9 Compare May 4, 2022 15:56
@ssbarnea ssbarnea force-pushed the feature/jsonschema branch 2 times, most recently from 1d37565 to 6911477 Compare May 10, 2022 09:09
@ssbarnea ssbarnea force-pushed the feature/jsonschema branch from 6911477 to 24b0a70 Compare May 10, 2022 09:27
@ssbarnea ssbarnea marked this pull request as ready for review May 10, 2022 09:45
@ssbarnea ssbarnea requested a review from a team as a code owner May 10, 2022 09:45
@ssbarnea ssbarnea requested review from a team, webknjaz, ganeshrn and priyamsahoo May 10, 2022 09:45
@ssbarnea ssbarnea merged commit 49377b8 into ansible:main May 10, 2022
@ssbarnea ssbarnea deleted the feature/jsonschema branch May 10, 2022 12:11
@ssbarnea ssbarnea removed skip-changelog Can be missed from the changelog. feature labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants