Upgrade var-naming rule to include role name prefix #3422

ssbarnea · 2023-05-09T14:44:02Z

Fixes: #3221
Fixes: #3197
Fixes: #2784

Fixes: #3221 Fixes: #3197 Fixes: #2784

gardar · 2023-05-16T12:39:04Z

@ssbarnea would it be possible to change the no-role-prefix role so that it will also accept leading underscores in front of the role name? Or better yet enforce the leading underscores for internal variables.
It's common practice in many roles that's adopted from python: https://peps.python.org/pep-0008/#descriptive-naming-styles

ssbarnea · 2023-05-16T14:10:16Z

@gardar Please raise a ticket for this request. I can understand your case, especially with an well establish code base. I already contacted @cidrblock so we can consult with others and see if we should relax this rule or not. For the moment you made the right call of temporary disabling it for your repo.

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | minor | `==6.15.0` -> `==6.17.2` | --- ### Release Notes <details> <summary>ansible/ansible-lint (ansible-lint)</summary> ### [`v6.17.2`](https://github.com/ansible/ansible-lint/releases/tag/v6.17.2) [Compare Source](ansible/ansible-lint@v6.17.1...v6.17.2) #### Bugfixes - Allow use as a reusable github action ([#3513](ansible/ansible-lint#3513)) [@ssbarnea](https://github.com/ssbarnea) - Add action and args properties to task class ([#3576](ansible/ansible-lint#3576)) [@ssbarnea](https://github.com/ssbarnea) - Fixed error when sarif file option is provided ([#3587](ansible/ansible-lint#3587)) [@ajinkyau](https://github.com/ajinkyau) - Add NetBSD as a recognized platform ([#3586](ansible/ansible-lint#3586)) [@he32](https://github.com/he32) - Display ansible-compat version alongwith with other deps ([#3584](ansible/ansible-lint#3584)) [@ajinkyau](https://github.com/ajinkyau) - Refactored syntax-checking ([#3568](ansible/ansible-lint#3568)) [@ssbarnea](https://github.com/ssbarnea) - Avoid app reinitialization during syntax-check ([#3563](ansible/ansible-lint#3563)) [@ssbarnea](https://github.com/ssbarnea) - Allow config file to have `.yaml` extension ([#3559](ansible/ansible-lint#3559)) [@bdsoha](https://github.com/bdsoha) - Allow lists of lists of strings for vars_files ([#3561](ansible/ansible-lint#3561)) [@ajinkyau](https://github.com/ajinkyau) ### [`v6.17.1`](https://github.com/ansible/ansible-lint/releases/tag/v6.17.1) [Compare Source](ansible/ansible-lint@v6.17.0...v6.17.1) #### Bugfixes - Update guess install method check ([#3553](ansible/ansible-lint#3553)) [@ajinkyau](https://github.com/ajinkyau) - Fix exclude logic bug that can cause cause partial linting ([#3552](ansible/ansible-lint#3552)) [@ssbarnea](https://github.com/ssbarnea) - Make profile information on summary line more clear ([#3545](ansible/ansible-lint#3545)) [@ssbarnea](https://github.com/ssbarnea) - Avoid adding pip related messages if installation method is different ([#3551](ansible/ansible-lint#3551)) [@ajinkyau](https://github.com/ajinkyau) - Avoid false positive with var-naming\[no-role-prefix] ([#3550](ansible/ansible-lint#3550)) [@ssbarnea](https://github.com/ssbarnea) - Make refresh_schemas handle firewalls that cut the file transfer midway ([#3546](ansible/ansible-lint#3546)) [@sverrehu](https://github.com/sverrehu) - Rename marketplace action ([#3548](ansible/ansible-lint#3548)) [@ssbarnea](https://github.com/ssbarnea) - Fix action name ([#3536](ansible/ansible-lint#3536)) [@coaxial](https://github.com/coaxial) - Handling of exclude paths with trailing slashs ([#3527](ansible/ansible-lint#3527)) [@hille721](https://github.com/hille721) - Ensure that rules collections use Runtime in offline mode ([#3526](ansible/ansible-lint#3526)) [@ssbarnea](https://github.com/ssbarnea) - Avoid using get_app() from inside the rule ([#3525](ansible/ansible-lint#3525)) [@ssbarnea](https://github.com/ssbarnea) - Avoid dependency error from rich ([#3517](ansible/ansible-lint#3517)) [@ssbarnea](https://github.com/ssbarnea) ### [`v6.17.0`](https://github.com/ansible/ansible-lint/releases/tag/v6.17.0) [Compare Source](ansible/ansible-lint@v6.16.2...v6.17.0) #### Minor Changes - fqcn\[deep]: detect deep plugins ([#3502](ansible/ansible-lint#3502)) [@ssbarnea](https://github.com/ssbarnea) #### Bugfixes - Reimplement file exclusion logic ([#3507](ansible/ansible-lint#3507)) [@ssbarnea](https://github.com/ssbarnea) - Check validity of 'become_method' values from code ([#3499](ansible/ansible-lint#3499)) [@ajinkyau](https://github.com/ajinkyau) - Fix role_name\_ prefix include_role var name error ([#3500](ansible/ansible-lint#3500)) [@ajinkyau](https://github.com/ajinkyau) - Hide pip error if not present ([#3494](ansible/ansible-lint#3494)) [@Et7f3](https://github.com/Et7f3) - Update formatter to avoid reporting paths with .. ([#3496](ansible/ansible-lint#3496)) [@ssbarnea](https://github.com/ssbarnea) - Remove false positive on 'cacheable' property of set_fact ([#3490](ansible/ansible-lint#3490)) [@ajinkyau](https://github.com/ajinkyau) - Add missing become_method plugins to the schema ([#3484](ansible/ansible-lint#3484)) [@ajinkyau](https://github.com/ajinkyau) - Add support for ansible-builder v3 schema ([#3480](ansible/ansible-lint#3480)) [@ajinkyau](https://github.com/ajinkyau) - Add Github Marketplace Action ([#3476](ansible/ansible-lint#3476)) [@ssbarnea](https://github.com/ssbarnea) - Add oracle linux 8.8 ([#3479](ansible/ansible-lint#3479)) [@facorazza](https://github.com/facorazza) - Revert ansible-compat vendoring ([#3478](ansible/ansible-lint#3478)) [@ssbarnea](https://github.com/ssbarnea) - Updated file or dir not found message ([#3474](ansible/ansible-lint#3474)) [@ajinkyau](https://github.com/ajinkyau) - Check for included role prefix instead of current one ([#3473](ansible/ansible-lint#3473)) [@ssbarnea](https://github.com/ssbarnea) ### [`v6.16.2`](https://github.com/ansible/ansible-lint/releases/tag/v6.16.2) [Compare Source](ansible/ansible-lint@v6.16.1...v6.16.2) #### Bugfixes - Update test dependencies ([#3470](ansible/ansible-lint#3470)) [@ssbarnea](https://github.com/ssbarnea) - Fix and document installing of requirements.yml files ([#3471](ansible/ansible-lint#3471)) [@ssbarnea](https://github.com/ssbarnea) - Do not ever exclude files given as arguments ([#3468](ansible/ansible-lint#3468)) [@ssbarnea](https://github.com/ssbarnea) - Ensure we return error if argument gives are not present ([#3467](ansible/ansible-lint#3467)) [@ssbarnea](https://github.com/ssbarnea) - Allow rules to expose all tags they can produce ([#3464](ansible/ansible-lint#3464)) [@ssbarnea](https://github.com/ssbarnea) - Enable var-name rule to detect read-only variables ([#3462](ansible/ansible-lint#3462)) [@ssbarnea](https://github.com/ssbarnea) - Add Oracle Enterprise Linux 7.\* ([#3463](ansible/ansible-lint#3463)) [@Rylon](https://github.com/Rylon) - Fix for var-naming rule to not break on include_tasks and vars ([#3458](ansible/ansible-lint#3458)) [@ajinkyau](https://github.com/ajinkyau) - var-naming now prevents use of Ansible reserved names ([#3460](ansible/ansible-lint#3460)) [@ssbarnea](https://github.com/ssbarnea) - Ensure that we also lint files from git submodules ([#3431](ansible/ansible-lint#3431)) [@ssbarnea](https://github.com/ssbarnea) - Adding 2.16 to the list of allowed ansible-core versions in meta-runtime rule ([#3455](ansible/ansible-lint#3455)) [@alisonlhart](https://github.com/alisonlhart) ### [`v6.16.1`](https://github.com/ansible/ansible-lint/releases/tag/v6.16.1) [Compare Source](ansible/ansible-lint@v6.16.0...v6.16.1) #### Bugfixes - Update lock file to use ansible-core 2.15.0 ([#3449](ansible/ansible-lint#3449)) [@ssbarnea](https://github.com/ssbarnea) - Install requirements from galaxy.yml and tests/requirements.yml ([#3446](ansible/ansible-lint#3446)) [@ssbarnea](https://github.com/ssbarnea) - Add Kali Linux as a supported platform ([#3448](ansible/ansible-lint#3448)) [@mcdonnnj](https://github.com/mcdonnnj) - Do not trigger no_handler upon complex conditions ([#3437](ansible/ansible-lint#3437)) [@klaus-tux](https://github.com/klaus-tux) - Hide warning about unique filter originating from core ([#3436](ansible/ansible-lint#3436)) [@ssbarnea](https://github.com/ssbarnea) - Relax ruamel-yaml requirements ([#3433](ansible/ansible-lint#3433)) [@ssbarnea](https://github.com/ssbarnea) - Suggest correct alternative for `with_filetree` ([#3432](ansible/ansible-lint#3432)) [@ErwinJanssen](https://github.com/ErwinJanssen) - Upgrade var-naming rule to include role name prefix ([#3422](ansible/ansible-lint#3422)) [@ssbarnea](https://github.com/ssbarnea) - Fix exception when using reformatting on scalars ([#3423](ansible/ansible-lint#3423)) [@ssbarnea](https://github.com/ssbarnea) - Find and lint imported playbooks ([#3413](ansible/ansible-lint#3413)) [@ajinkyau](https://github.com/ajinkyau) ### [`v6.16.0`](https://github.com/ansible/ansible-lint/releases/tag/v6.16.0) [Compare Source](ansible/ansible-lint@v6.15.0...v6.16.0) #### Minor Changes - Capture python warnings and report some of them as matches ([#3324](ansible/ansible-lint#3324)) [@ssbarnea](https://github.com/ssbarnea) - Capture and hide ansible core warnings by default ([#3361](ansible/ansible-lint#3361)) [@ssbarnea](https://github.com/ssbarnea) - Remove progressive mode ([#3350](ansible/ansible-lint#3350)) [@ssbarnea](https://github.com/ssbarnea) - Enforce use of lineno variable name inside the library ([#3326](ansible/ansible-lint#3326)) [@ssbarnea](https://github.com/ssbarnea) #### Bugfixes - Add Amazon Linux 2023 as a supported platform ([#3405](ansible/ansible-lint#3405)) [@artis3n](https://github.com/artis3n) - Capture python warnings and report some of them as matches ([#3324](ansible/ansible-lint#3324)) [@ssbarnea](https://github.com/ssbarnea) - Fix missing required arguments issue from args rule ([#3402](ansible/ansible-lint#3402)) [@ajinkyau](https://github.com/ajinkyau) - Change matchtask to receive a Task instance ([#3403](ansible/ansible-lint#3403)) [@ssbarnea](https://github.com/ssbarnea) - Require ruamel.yaml>=0.17.24 ([#3406](ansible/ansible-lint#3406)) [@ssbarnea](https://github.com/ssbarnea) - Avoid exception when trying to load invalid text files ([#3399](ansible/ansible-lint#3399)) [@ssbarnea](https://github.com/ssbarnea) - Fix ansible collection path detection ([#3398](ansible/ansible-lint#3398)) [@ssbarnea](https://github.com/ssbarnea) - ruff: Address FBT002 ([#3389](ansible/ansible-lint#3389)) [@shatakshiiii](https://github.com/shatakshiiii) - More pathlib adoption ([#3390](ansible/ansible-lint#3390)) [@ssbarnea](https://github.com/ssbarnea) - Avoid dropping comments on YAML transformation ([#3392](ansible/ansible-lint#3392)) [@ssbarnea](https://github.com/ssbarnea) - Correct docs on navigator schema location ([#3394](ansible/ansible-lint#3394)) [@yajo](https://github.com/yajo) - Fix changelog schema for connection plugins ([#3388](ansible/ansible-lint#3388)) [@Qalthos](https://github.com/Qalthos) - Migrate from os.path to pathlib ([#3384](ansible/ansible-lint#3384)) [@ssbarnea](https://github.com/ssbarnea) - Remove resolvelib from requirements lock ([#3387](ansible/ansible-lint#3387)) [@ssbarnea](https://github.com/ssbarnea) - Make cwd use pathlib ([#3383](ansible/ansible-lint#3383)) [@ssbarnea](https://github.com/ssbarnea) - ruff: Address PGH ([#3380](ansible/ansible-lint#3380)) [@ssbarnea](https://github.com/ssbarnea) - ruff: Address A ([#3379](ansible/ansible-lint#3379)) [@ssbarnea](https://github.com/ssbarnea) - ruff: Address B ([#3377](ansible/ansible-lint#3377)) [@ssbarnea](https://github.com/ssbarnea) - ruff: Address SLF ([#3372](ansible/ansible-lint#3372)) [@ssbarnea](https://github.com/ssbarnea) - ruff: Address `SIM` ([#3373](ansible/ansible-lint#3373)) [@shatakshiiii](https://github.com/shatakshiiii) - ruff: Address EXE ([#3367](ansible/ansible-lint#3367)) [@ssbarnea](https://github.com/ssbarnea) - ruff: Address BLE ([#3368](ansible/ansible-lint#3368)) [@shatakshiiii](https://github.com/shatakshiiii) - ruff: Address INP and PLW ([#3366](ansible/ansible-lint#3366)) [@ssbarnea](https://github.com/ssbarnea) - Add initial handling of submodules to contribution docs ([#3362](ansible/ansible-lint#3362)) [@klaus-tux](https://github.com/klaus-tux) - ruff: Address T and RET ([#3364](ansible/ansible-lint#3364)) [@ssbarnea](https://github.com/ssbarnea) - Find "changed" not only in first "when" condition ([#3358](ansible/ansible-lint#3358)) [@klaus-tux](https://github.com/klaus-tux) - ruff: fix S rule ([#3363](ansible/ansible-lint#3363)) [@ssbarnea](https://github.com/ssbarnea) - Make MatchError a dataclass ([#3345](ansible/ansible-lint#3345)) [@ssbarnea](https://github.com/ssbarnea) - Remove `EM` from ruff ignores ([#3356](ansible/ansible-lint#3356)) [@shatakshiiii](https://github.com/shatakshiiii) - Mock jinja filters to prevent templating errors ([#3355](ansible/ansible-lint#3355)) [@ssbarnea](https://github.com/ssbarnea) - Update schema files ([#3354](ansible/ansible-lint#3354)) [@ssbarnea](https://github.com/ssbarnea) - Add Fedora 38 to meta.json schema file ([#3353](ansible/ansible-lint#3353)) [@Marek-Mantaj-Mobica](https://github.com/Marek-Mantaj-Mobica) - Remove `RUF` from ruff ignores ([#3346](ansible/ansible-lint#3346)) [@ajinkyau](https://github.com/ajinkyau) - Remove `G` from ruff ignores ([#3332](ansible/ansible-lint#3332)) [@shatakshiiii](https://github.com/shatakshiiii) - Remove `ISC` from ruff ignores ([#3342](ansible/ansible-lint#3342)) [@shatakshiiii](https://github.com/shatakshiiii) - Remove `C` from ruff ignores ([#3343](ansible/ansible-lint#3343)) [@ajinkyau](https://github.com/ajinkyau) - Make linter configuration a dataclass ([#3334](ansible/ansible-lint#3334)) [@ssbarnea](https://github.com/ssbarnea) - Remove `N` from ruff ignores ([#3328](ansible/ansible-lint#3328)) [@shatakshiiii](https://github.com/shatakshiiii) - Remove useless . from additional_dependencies in pre-commit hook ([#3327](ansible/ansible-lint#3327)) [@trallnag](https://github.com/trallnag) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Nicolas Dufour <nrdufour@gmail.com> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/9 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>

ssbarnea requested a review from a team as a code owner May 9, 2023 14:44

ssbarnea requested review from a team, audgirka, priyamsahoo and shatakshiiii May 9, 2023 14:44

github-actions bot added the skip-changelog Can be missed from the changelog. label May 9, 2023

ssbarnea added bug and removed skip-changelog Can be missed from the changelog. labels May 9, 2023

ssbarnea requested a review from cidrblock May 9, 2023 14:46

github-actions bot added the skip-changelog Can be missed from the changelog. label May 9, 2023

ssbarnea force-pushed the chore/path branch from 94d8905 to 08c9592 Compare May 10, 2023 10:42

Upgrade var-naming rule to include role name prefix

dc19d21

Fixes: #3221 Fixes: #3197 Fixes: #2784

ssbarnea force-pushed the chore/path branch from 08c9592 to dc19d21 Compare May 10, 2023 13:13

ssbarnea removed the skip-changelog Can be missed from the changelog. label May 10, 2023

ssbarnea mentioned this pull request May 10, 2023

Extend the var_naming rule to also check for the role name #3221

Closed

cidrblock approved these changes May 10, 2023

View reviewed changes

ssbarnea merged commit de31335 into main May 10, 2023

ssbarnea deleted the chore/path branch May 10, 2023 15:41

hswong3i added a commit to alvistack/ansible-collection-ceph that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

a5972bf

hswong3i added a commit to alvistack/ansible-collection-gitlab that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

34924c5

hswong3i added a commit to alvistack/ansible-role-audacious that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

8c38387

hswong3i added a commit to alvistack/ansible-role-ansible that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

f7e6b52

hswong3i added a commit to alvistack/ansible-collection-gnome that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

7663749

hswong3i added a commit to alvistack/ansible-role-bootstrap that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

f954003

hswong3i added a commit to alvistack/ansible-collection-kubernetes that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

6a696a1

hswong3i added a commit to alvistack/ansible-role-bitbucket that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

ede0527

hswong3i added a commit to alvistack/ansible-role-audacity that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

51b626d

hswong3i added a commit to alvistack/ansible-role-bleachbit that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

f8edb08

hswong3i added a commit to alvistack/ansible-role-buildah that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

149f961

hswong3i added a commit to alvistack/ansible-role-blender that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

57b4dce

hswong3i added a commit to alvistack/docker-fedora that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

b9a5cc8

hswong3i added a commit to alvistack/docker-dnsmasq that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

e458f85

hswong3i added a commit to alvistack/docker-gitlab-ce that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

1878a8e

hswong3i added a commit to alvistack/docker-fisheye that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

11c6609

hswong3i added a commit to alvistack/docker-gitlab-ee that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

cb18065

hswong3i added a commit to alvistack/docker-httpd that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

df28c08

hswong3i added a commit to alvistack/docker-jira that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

71916e5

hswong3i added a commit to alvistack/docker-mariadb that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

f848282

hswong3i added a commit to alvistack/docker-mitmproxy that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

44c87d6

hswong3i added a commit to alvistack/docker-opensuse that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

301e4f4

hswong3i added a commit to alvistack/docker-php-fpm that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

65a282c

hswong3i added a commit to alvistack/docker-postfix that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

8f32753

hswong3i added a commit to alvistack/docker-postgres that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

478a72b

hswong3i added a commit to alvistack/docker-rhel that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

46cda08

hswong3i added a commit to alvistack/vagrant-centos that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

61bc506

hswong3i added a commit to alvistack/docker-ubuntu that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

366d214

hswong3i added a commit to alvistack/vagrant-ceph that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

025093d

hswong3i added a commit to alvistack/vagrant-devel that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

3d39fd0

hswong3i added a commit to alvistack/vagrant-debian that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

98fd231

hswong3i added a commit to alvistack/vagrant-fedora that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

3bdad5b

hswong3i added a commit to alvistack/vagrant-kubernetes that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

4524bec

hswong3i added a commit to alvistack/vagrant-opensuse that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

dce41f3

hswong3i added a commit to alvistack/vagrant-rhel that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

1527824

hswong3i added a commit to alvistack/vagrant-ubuntu that referenced this pull request May 16, 2023

https://github.com/ansible/ansible-lint/pull/3422

fa9e449

gardar mentioned this pull request May 16, 2023

fix: don't require role name on internal vars prometheus-community/ansible#109

Merged

gardar mentioned this pull request May 16, 2023

Allow/enforce underscore prefixed internal variables #3452

Closed

erichiller mentioned this pull request Aug 21, 2024

Fix for 'var-naming warns on variables with dynamically set names' removed #4296

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade var-naming rule to include role name prefix #3422

Upgrade var-naming rule to include role name prefix #3422

ssbarnea commented May 9, 2023

gardar commented May 16, 2023

ssbarnea commented May 16, 2023

Upgrade var-naming rule to include role name prefix #3422

Upgrade var-naming rule to include role name prefix #3422

Conversation

ssbarnea commented May 9, 2023

gardar commented May 16, 2023

ssbarnea commented May 16, 2023