Sanity Rule Ignore Additions and Updates #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonlhart
requested review from
a team,
audgirka,
priyamsahoo and
Ruchip16
alisonlhart
force-pushed
the
sanity-ignore-additions
branch
from
00fdaec
to
068bc01
Compare
ssbarnea
approved these changes
Sep 22, 2023
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Oct 3, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==6.20.0` -> `==6.20.1` | --- ### Release Notes <details> <summary>ansible/ansible-lint (ansible-lint)</summary> ### [`v6.20.1`](https://github.com/ansible/ansible-lint/releases/tag/v6.20.1) [Compare Source](ansible/ansible-lint@v6.20.0...v6.20.1) #### Bugfixes - Fix detection of play roles vars missing prefix ([#​3765](ansible/ansible-lint#3765)) [@​cavcrosby](https://github.com/cavcrosby) - Prune reported errors after autofix ([#​3774](ansible/ansible-lint#3774)) [@​cidrblock](https://github.com/cidrblock) - `--fix` will now default to `all` ([#​3777](ansible/ansible-lint#3777)) [@​ajinkyau](https://github.com/ajinkyau) - Avoid false error caused by TypeError with jinja rule ([#​3773](ansible/ansible-lint#3773)) [@​ssbarnea](https://github.com/ssbarnea) - Sanity Rule Ignore Additions and Updates ([#​3766](ansible/ansible-lint#3766)) [@​alisonlhart](https://github.com/alisonlhart) - Update rulebook schema (name is now required) ([#​3776](ansible/ansible-lint#3776)) [@​ssbarnea](https://github.com/ssbarnea) - Expose rules that have autofix capability in docs ([#​3770](ansible/ansible-lint#3770)) [@​shatakshiiii](https://github.com/shatakshiiii) - List all the fixable rules in CLI via `--list-rules` ([#​3737](ansible/ansible-lint#3737)) [@​shatakshiiii](https://github.com/shatakshiiii) - Include level in SARIF results ([#​3758](ansible/ansible-lint#3758)) [@​ssbarnea](https://github.com/ssbarnea) - Meta runtime supported version update ([#​3755](ansible/ansible-lint#3755)) [@​alisonlhart](https://github.com/alisonlhart) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/120 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
sanityrule so the rule only checks for ignores under theplugins/androles/directories.ansible-test sanityonly cares about these directories, so ignoring tests outside of them does not affect sanity testing.For example, an ignore entry for a "disallowed-ignore" under the
tests/dir will no longer get flagged.This rule also now skips checking unsupported versions of Ansible/ansible-core, aka 2.9, 2.10, 2.11, and 2.12.