Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use github action path for running ansible lint #3798

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Do not use github action path for running ansible lint #3798

merged 2 commits into from
Sep 30, 2023

Conversation

ReenigneArcher
Copy link
Contributor

@ReenigneArcher ReenigneArcher commented Sep 29, 2023 •
edited
Loading

  • Allow user to specify the working directory of the ansible-lint command
  • Default working directory will be the github.workspace instead of github.action_path
  • Allow user to skip installing python if they already have a specific version of python setup
  • Removes the checkout step... a normal expectation is that the user will checkout their own repository... and when this action does so it overwrites any customizations/edits the user has done to their directory (such as creating a vault password file).

Fixes the following issues:

@ReenigneArcher ReenigneArcher requested a review from a team as a code owner September 29, 2023 20:40
@ReenigneArcher ReenigneArcher temporarily deployed to ack September 29, 2023 20:40 — with GitHub Actions Inactive
ReenigneArcher
ReenigneArcher commented Sep 29, 2023
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@ReenigneArcher ReenigneArcher temporarily deployed to ack September 29, 2023 20:45 — with GitHub Actions Inactive
@ReenigneArcher
fix: do not use github action path for running ansible lint and...
c618800 
- Allow user to specify the working directory of the `ansible-lint` command
- Default working directory will be the `github.workspace` instead of `github.action_path`
- Allow user to skip installing python if they already have a specific version of python setup
@ReenigneArcher ReenigneArcher temporarily deployed to ack September 29, 2023 20:50 — with GitHub Actions Inactive
@ssbarnea ssbarnea added the bug label Sep 30, 2023
@ssbarnea ssbarnea temporarily deployed to ack September 30, 2023 14:48 — with GitHub Actions Inactive
ssbarnea

This comment was marked as resolved.

Sign in to view

@ssbarnea ssbarnea temporarily deployed to ack September 30, 2023 14:54 — with GitHub Actions Inactive
@ssbarnea ssbarnea changed the title fix: do not use github action path for running ansible lint and... Do not use github action path for running ansible lint Sep 30, 2023
@ssbarnea ssbarnea merged commit 55b8b66 into ansible:main Sep 30, 2023
18 checks passed
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Oct 3, 2023
@nrdufour
chore(deps): update dependency ansible-lint to v6.20.2 (#123)
b75ec51 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==6.20.1` -> `==6.20.2` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the logs for more information.

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v6.20.2`](https://github.com/ansible/ansible-lint/releases/tag/v6.20.2)

[Compare Source](ansible/ansible-lint@v6.20.1...v6.20.2)

#### Bugfixes

-   Do not use github action path for running ansible lint ([#&#8203;3798](ansible/ansible-lint#3798)) [@&#8203;ReenigneArcher](https://github.com/ReenigneArcher)
-   Correct listing of autofix rules in documentation ([#&#8203;3797](ansible/ansible-lint#3797)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Make the autofix rule list dynamic in documentation ([#&#8203;3785](ansible/ansible-lint#3785)) [@&#8203;shatakshiiii](https://github.com/shatakshiiii)
-   Fix documentation links to autofix page ([#&#8203;3796](ansible/ansible-lint#3796)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Bump test dependencies ([#&#8203;3795](ansible/ansible-lint#3795)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Correct documentation regarding CLI argument precedence ([#&#8203;3792](ansible/ansible-lint#3792)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Document autofix ability for rules that supports it ([#&#8203;3791](ansible/ansible-lint#3791)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Accept underline prefix when checking var-naming ([#&#8203;3789](ansible/ansible-lint#3789)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Correct regression with use of --fix ([#&#8203;3783](ansible/ansible-lint#3783)) [@&#8203;ssbarnea](https://github.com/ssbarnea)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/123
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
@ptoscano ptoscano mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The vault password file was not found
2 participants
@ReenigneArcher @ssbarnea