Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for ansible binary in the same path as we are #3903

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

FliegenKLATSCH
Copy link
Contributor

If the PATH is not set up correctly and we are invoked via full path, it's likely that ansible itself is just next to us.
It's added at the end, so it's only the last resort, if nothing else could be found.

@FliegenKLATSCH FliegenKLATSCH requested a review from a team as a code owner November 19, 2023 20:01
@FliegenKLATSCH FliegenKLATSCH requested review from a team, cristianonicolai and shatakshiiii and removed request for a team November 19, 2023 20:01
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will clearly not work as expected if linter is called as a python module as in this case argv[0] will be just python.

@FliegenKLATSCH
Copy link
Contributor Author

True, but in the worst case we add the path of python itself at the end, which usually should be there already?
Maybe I am overlooking something?

@ssbarnea
Copy link
Member

@FliegenKLATSCH Please make it report green on all jobs and I will accept it.

@ssbarnea ssbarnea merged commit 90fb69a into ansible:main Nov 29, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants