Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update task name in notify for a task against name[casing] error #4038

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Update task name in notify for a task against name[casing] error #4038

merged 2 commits into from
Feb 26, 2024

Conversation

audgirka
Copy link
Contributor

Fixes: #4028

@audgirka audgirka requested a review from a team as a code owner February 20, 2024 09:50
@audgirka audgirka requested review from cristianonicolai and shatakshiiii and removed request for a team February 20, 2024 09:50
@github-actions github-actions bot added the bug label Feb 20, 2024
ssbarnea
ssbarnea requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the example from https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_handlers.html#naming-handlers you will also have to update the 'listen' inside handlers to capitalize it too, or otherwise you will might break notify when it does refer to a topic (instead of name).

@ssbarnea ssbarnea merged commit 0233c19 into main Feb 26, 2024
23 checks passed
@ssbarnea ssbarnea deleted the fix/handle_notify branch February 26, 2024 10:30
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Mar 14, 2024
@nrdufour
chore(deps): update dependency ansible-lint to v24.2.1 (#434)
fcd643b 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ansible-lint](https://github.com/ansible/ansible-lint) ([changelog](https://github.com/ansible/ansible-lint/releases)) | patch | `==24.2.0` -> `==24.2.1` |

---

### Release Notes

<details>
<summary>ansible/ansible-lint (ansible-lint)</summary>

### [`v24.2.1`](https://github.com/ansible/ansible-lint/releases/tag/v24.2.1)

[Compare Source](ansible/ansible-lint@v24.2.0...v24.2.1)

#### Bugfixes

-   Fix error suppression when syntax is incorrect ([#&#8203;4026](ansible/ansible-lint#4026)) [@&#8203;audgirka](https://github.com/audgirka)
-   Set global `cache_dir_lock` ([#&#8203;4055](ansible/ansible-lint#4055)) [@&#8203;guppy0130](https://github.com/guppy0130)
-   \[role-name] Handle string role dependencies ([#&#8203;4054](ansible/ansible-lint#4054)) [@&#8203;corubba](https://github.com/corubba)
-   Support for upcoming Ubuntu 24.04 and Fedora 40 ([#&#8203;4051](ansible/ansible-lint#4051)) [@&#8203;mafalb](https://github.com/mafalb)
-   Update documentation for syntax-check\[unknown-module] ([#&#8203;4049](ansible/ansible-lint#4049)) [@&#8203;ssbarnea](https://github.com/ssbarnea)
-   Add OpenWRT 23.05 to valid versions ([#&#8203;4041](ansible/ansible-lint#4041)) [@&#8203;jonkerj](https://github.com/jonkerj)
-   Update task name in `notify` for a task against `name[casing]` error ([#&#8203;4038](ansible/ansible-lint#4038)) [@&#8203;audgirka](https://github.com/audgirka)
-   accept yum history and info as valid commands ([#&#8203;4025](ansible/ansible-lint#4025)) [@&#8203;konstruktoid](https://github.com/konstruktoid)
-   Add attributes for role argument specs ([#&#8203;4018](ansible/ansible-lint#4018)) [@&#8203;felixfontein](https://github.com/felixfontein)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDEuMSIsInVwZGF0ZWRJblZlciI6IjM3LjI0MS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Nicolas Dufour <nrdufour@gmail.com>
Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/434
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

@cristianonicolai cristianonicolai Awaiting requested review from cristianonicolai cristianonicolai is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible-Lint uppercases handler names but ignores the notifications
2 participants
@audgirka @ssbarnea