Fix cmd args with no-free-form transformer #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qalthos
requested review from
priyamsahoo and
shatakshiiii
and removed request for
a team
Qalthos
changed the title
Qalthos
force-pushed
the
fix/spurious-cmd
branch
from
05a4028
to
3b7fdc6
Compare
The changed_when avoids this. This appears to be an unrelated issue, but can be worked around this way.
Qalthos
force-pushed
the
fix/spurious-cmd
branch
from
3b7fdc6
to
190942f
Compare
ssbarnea
changed the title
ssbarnea
approved these changes
Jun 14, 2024
ssbarnea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a specific callout for using msg with debug, but all other inline module args would generate a cmd arg even if nothing went into it. This generalizes the approach (though it assumes that anything that doesn't fit should go into a cmd arg)
Fixes #4189