Fix for ignoring test / directories by fqcn[deep] rule

[tanwigeetika1618]

Fix issue #4160

Description:

This PR addresses issue #4160 by modifying the logic in fqcn.py to ensure that directories related to testing (i.e., those starting with "test") are skipped during processing. Previously, test directories were being evaluated, leading to unnecessary false positive warnings. (Skip test folders in fqcn.py)

Changes:

• Updated the condition in fqcn.py to check if a directory is a test folder.
• The folder checking logic has been enhanced to search for the word "test" anywhere in the directory path.
  • Directories that include "test" (such as test, tests, testxyz, or abctest) are skipped.
  • This ensures that test-related directories are excluded from processing while maintaining standard plugin structure.
• Added a new test case test_fqcn_deep_test_dir_pass to verify that the rule does not flag files located in directories named test or similar.

Testing:

The new logic has been tested with various directory structures to ensure that any directory containing the word "test" is correctly skipped. The following cases have been verified:

1. /tests/unit/plugins/action/network/pr.py
2. /abc/unit/plugins/action/tests/pr.py
3. /abc/test/plugins/action/network/pr.py
4. /abctests/unit/plugins/action/network/pr.py
5. /testxyz/unit/plugins/action/network/pr.py

In all these cases, the test directories (or directories containing "test") were successfully ignored during processing.

[alisonlhart]

Looks good! There should probably be a test added case to check this, following the pattern of the other test cases in the fqcn.py rule. One of the test cases you used during development would be good to add in.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud