Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid running application initialization twice #4335

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Avoid running application initialization twice #4335

merged 1 commit into from
Sep 19, 2024

Conversation

ssbarnea
Copy link
Member

Related: #4219

@ssbarnea ssbarnea requested a review from a team as a code owner September 18, 2024 16:08
@ssbarnea ssbarnea requested review from audgirka and shatakshiiii and removed request for a team September 18, 2024 16:08
@github-actions github-actions bot added the bug label Sep 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tanwigeetika1618
tanwigeetika1618 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@tanwigeetika1618 tanwigeetika1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR look good to me. The caching mechanism in get_app seems well-implemented, and updating ruff-pre-commit to the latest version is appropriate. The test adjustments also ensure that caching doesn’t interfere with the test runs.

@ssbarnea ssbarnea merged commit 571711f into main Sep 19, 2024
26 checks passed
@ssbarnea ssbarnea deleted the fix/code branch September 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanwigeetika1618 tanwigeetika1618 tanwigeetika1618 approved these changes

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @tanwigeetika1618