Utilize create_matcherror more in other rules #4408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
The imports of the MatchError class have been moved under the TYPE_CHECKING conditional because the rules changed now only rely solely on the class for typing, and no longer require it at runtime.
cavcrosby
force-pushed
the
utilize-create-matcherror
branch
from
af57bd0
to
54f255a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the
var-namingrule the other day, I wondered why this rule didn't use thecreate_matcherrormethod like other rules. Hence, to keep consistent with other rules, I added the method to rules still explicitly creatingMatchErrorinstances.