Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions for plugins #56

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Add descriptions for plugins #56

merged 1 commit into from
Nov 19, 2024

Conversation

djyasin
Copy link
Member

@djyasin djyasin commented Nov 14, 2024

Add descriptions for plugins

@djyasin djyasin force-pushed the update_cloud_providers_and_cloud_constants_28722 branch from 9f9b356 to d86e798 Compare November 14, 2024 21:41
@djyasin djyasin force-pushed the update_cloud_providers_and_cloud_constants_28722 branch from 7af9475 to ae262fa Compare November 15, 2024 14:52
webknjaz
webknjaz previously approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still need to remain a draft?

P.S. Note that all of the revert+fixup+wip commit titles will end up on devel.

src/awx_plugins/inventory/plugins.py Outdated Show resolved Hide resolved
@djyasin djyasin marked this pull request as ready for review November 18, 2024 14:32
@webknjaz
Copy link
Member

@djyasin with all the changes back and forth, Codecov seems to be confused. Could you rebase to see if that'll fix the problem?

@djyasin
Add descriptions for plugins
c3f899d 
Update src/awx_plugins/inventory/plugins.py

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Remove incorrect changes.
@djyasin djyasin force-pushed the update_cloud_providers_and_cloud_constants_28722 branch from ca34822 to c3f899d Compare November 19, 2024 18:55
@djyasin
Copy link
Member Author

djyasin commented Nov 19, 2024

@djyasin with all the changes back and forth, Codecov seems to be confused. Could you rebase to see if that'll fix the problem?

I just rebased and squashed, let me know if that looks better!

@webknjaz
Copy link
Member

@djyasin perfect! Codecov no longer reports 0% patch coverage. The commit description could be cleaned up, but that's not a hard blocker. So let's not delay merging any further.

@webknjaz webknjaz added the enhancement New feature or request label Nov 19, 2024
@webknjaz webknjaz enabled auto-merge November 19, 2024 22:09
@webknjaz webknjaz added this pull request to the merge queue Nov 19, 2024
@webknjaz
Copy link
Member

@djyasin post-merge instructions:

  1. Click Run workflow @ https://github.com/ansible/awx-plugins/actions/workflows/ci-cd.yml, entering 0.0.1a7 precisely in the version field. Don't enter anything else, and submit the form.
  2. Wait until the newly created workflow run completes tests and pauses, then approve releasing on the workflow run summary page.
  3. Wait until the workflow run completes fully.
  4. Make sure awx gets the new version. Make a PR bumping the dependency over there if necessary.

Merged via the queue into ansible:devel with commit 2e5e979 Nov 19, 2024
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djyasin @webknjaz