Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InstanceGroup and Add Build Runner in MAKEFILE #162

Open
wants to merge 12 commits into
base: devel
Choose a base branch
from

Conversation

neevnuv
Copy link
Contributor

@neevnuv neevnuv commented May 31, 2024

This PR is a bundle of small changes that fixes the usage of InstanceGroup CR and separates instancegroups and container groups in the UI and description.

Changes:

  • Rename policy_spec_override to pod_spec_override to allign with the awx collection. Plus, after looking into the code of the runner, the environment variable of POLICY_SPEC_OVERRIDE was never used.
  • Added variables for max_concurrent_jobs and max_forks in CSV and CRD of instanceGroup.
  • Remove the credential from required. This is due to the credential only being needed for credentialGroups and not for instanceGroups.
  • Adjusted the CSV to show InstanceGroup variables when is_credential_group is false and show ContainerGroup variables when is_credential_group is true
  • Added in make file a small part to allow building the runner image. In the future should add an option to specify the runner image in the deploy. Plus added a line about this in the documentation.
  • Moved the instance group samlpes in a directory for instancegroups. Then added a CR that deploys a ContainerGroup and another that deploy an InstanceGroup.
  • Added ifs to the job definition template of the instance group to not require all the variables to be specified.

This was opened to solve #161

@neevnuv
Copy link
Contributor Author

neevnuv commented May 31, 2024

Thanks for running the pipelines.
I see changing the samples file location failed the pipeline, I'll fix it.

neevnuv and others added 5 commits May 31, 2024 22:25
…n samples

In the previous commits I move all the instanceGroups into a single directory. but I forgot to change this in the CI. Now I fix this in the CI.
@neevnuv
Copy link
Contributor Author

neevnuv commented Jun 10, 2024

hi @rooftopcellist, I think the PR is ready. I would love it if you would go over it and merge it 😁

Copy link

sonarcloud bot commented Jul 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant