Replace pkg_resources with importlib.metadata
#15441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
force-pushed
the
maintenance/modern-entry-points
branch
from
e12ba1a
to
82af425
Compare
|
|
@chrismeyersfsu @TheRealHaoLiu looks like I can't request reviews in this repo, but perhaps you could merge it already? |
webknjaz
commented
Aug 29, 2024
| import pkg_resources | ||
|
|
||
| __version__ = pkg_resources.get_distribution('awx').version | ||
| except pkg_resources.DistributionNotFound: |
There was a problem hiding this comment.
LOL, this line errors out with a NameError because it never exists prior to the import.
TheRealHaoLiu
approved these changes
Sep 13, 2024
webknjaz
force-pushed
the
maintenance/modern-entry-points
branch
from
82af425
to
b2e6cd8
Compare
It's been deprecated for quite a while. Additionally, it's coming from an undeclared runtime dependency of `setuptools`.
auto-merge was automatically disabled
September 13, 2024 17:24
Head branch was pushed to by a user without write access
webknjaz
force-pushed
the
maintenance/modern-entry-points
branch
from
b2e6cd8
to
2d16514
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been deprecated for quite a while. Additionally, it's coming from an undeclared runtime dependency of
setuptools.