Disable lazy loading on my content #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are a lot of unused variables in project and they are mostly represented as unused imports. There are also some unused variables in scope of module and function definitions as well as some unused private fields of TS classes. This patch enables no-unused-variable rule in tslint config. Due to the fact that it's not possible to check only unused imports, other rule warnings must be fixed too. So this patch includes removal of all unused variables found in function bodies and variables declared but unused in scope of module. All unused constructor args are removed too since Angular dependency injection is not dependent on argument order. Signed-off-by: Ivan Remizov <iremizov@gmail.com> (cherry picked from commit 22206bf)
(cherry picked from commit f39d0c1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport: #922